Only export LIBCLANG_PATH when override=true#36
Closed
chrysn wants to merge 2 commits intoesp-rs:mainfrom
Closed
Conversation
chrysn
force-pushed
the
libclang-path-override
branch
from
9eb1ad3 to
df455f1
Compare
This is primarily useful for hands-off environments where the paths are not exported by default (otherwise, downstream actions would need to hard-code this action's choice of export file), and conveniently allows eliding the parameter during installation (because the variable is used by espup).
Closed
chrysn
force-pushed
the
libclang-path-override
branch
from
f469d01 to
1f20228
Compare
Contributor
Author
|
Closing this in favor of #38 -- that one does appear cleaner and is not really much more effort to maintain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #35
This is the simple approach (reusing the
overridetunable); discussion in #35 will need to show whether that is an acceptable change, or whether a new tunable is needed.